Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use actual image data instead of image URL #76

Closed
jiri-janousek opened this issue Feb 5, 2015 · 2 comments
Closed

Allow to use actual image data instead of image URL #76

jiri-janousek opened this issue Feb 5, 2015 · 2 comments
Assignees
@jiri-janousek

Comments

@jiri-janousek
Copy link
Member

jiri-janousek commented Feb 5, 2015 •
edited
Loading

This issue has been fixed in the master branch and will be released in the next rebuilt of packages. Thanks for making Nuvola Player better by filing bug reports.

If album art download requires authorized access (session), it cannot be downloaded outside outside the browser session (dschep/nuvola-app-synology-audio-station#3). Therefore, wee need another way how to provide Nuvola Player core with the album art image.

Idea:

  1. Get actual image data via XMLHttpRequest
  2. Pass it to Nuvola Player core as artData parameter instead of artLocation.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@jiri-janousek jiri-janousek mentioned this issue Nov 15, 2016
Closed
17 tasks
@jiri-janousek
Copy link
Member Author

In progress, necessary for SiriusXM

jiri-janousek added a commit that referenced this issue Nov 26, 2016
@jiri-janousek
Download album art with WebKit's NetworkProcess
a84bbaf 
The NetworkProcess and its session can download images with restricted
access.

Issue: #76

Signed-off-by: Jiří Janoušek <[email protected]>
@jiri-janousek
Copy link
Member Author

This issue has been fixed in the master branch and will be released in the next rebuilt of packages. Thanks for making Nuvola Player better by filing bug reports.

@ghost ghost assigned jiri-janousek Nov 26, 2016
@ghost ghost removed the in progress label Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiri-janousek jiri-janousek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiri-janousek