Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine HTML5 Audio support in Google Play [$30] #91

Closed
jiri-janousek opened this issue Apr 8, 2015 · 56 comments
Closed

Examine HTML5 Audio support in Google Play [$30] #91

jiri-janousek opened this issue Apr 8, 2015 · 56 comments

Comments

@jiri-janousek
Copy link
Member

jiri-janousek commented Apr 8, 2015

  • Chromium can play without Flash plugin. Same for Electron-based apps, e.g. Kill Flash MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#60
  • HTML5 Audio works in Nuvola Player 3.1 in all supported distributions but only with accounts without All Access subscription. Make sure the Flash plugin is disabled (App menu/Gear menu → Format support → Web plugins → Toggle "Load web plugins (Flash)" off, then restart Nuvola Player) and MP3 decoder is installed (App menu/Gear menu → Format support → HTML5 Audio).
  • Media Source Extension (MSE) and Chrome's user agent are probably necessary for complete support. Not sure about Encrypted Media Extension (EME) though.

❤️ Two Nuvola Patrons are interested in this feature. Internal info: (1). GitHub: @brianredbeard

There is a $30 open bounty on this issue. Add to the bounty at Bountysource.

@jiri-janousek jiri-janousek added this to the 3.0.0 milestone Jul 7, 2015
@jiri-janousek jiri-janousek changed the title Examine HTML5 Audio support in Google Play Examine HTML5 Audio support in Google Play [$15] Jul 23, 2015
@mcg
Copy link

mcg commented Jul 23, 2015

I know $15 isn't much, but I can't use Nuvola anymore as I've removed Flash from all my systems.

@jiri-janousek
Copy link
Member Author

You could try Rdio. It supports HTML5 audio nicely.

@mcg
Copy link

mcg commented Aug 7, 2015

Kind of invested in Google Play. HTML5 playback works in Chrome, but I am guessing it's, some DRM module Chrome is shipping.

@jiri-janousek
Copy link
Member Author

Related ticket in Radiant Player: radiant-player/radiant-player-mac#335

@jiri-janousek jiri-janousek removed this from the 3.0.0 milestone Feb 19, 2016
@jiri-janousek
Copy link
Member Author

HTML5 Audio seems to work in Nuvola Player 3.1 in Debian Jessie for songs in the library, not sure about All Access Music subscription. Can anybody interested investigate? First, disable the Flash plugin in App menu/Gear menu → Format support → Web plugins → Toggle "Load web plugins (Flash)" off, then restart Nuvola Player.

@jnv
Copy link

jnv commented Mar 23, 2016

I have Nuvola Player 3.0.1 and All Access; unfortunately I cannot build version 3.1 now. With Flash Player disabled, Google Play insists on installing Flash Player and refuses to play anything (even my uploads).

However apparently it can be done with HTML5 audio. Google Play Music Desktop Player recently switched to Electron and got rid of Flash Player in the process: MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#60

@jiri-janousek
Copy link
Member Author

Thanks @jnv. However, I'm particularly interested in a feedback about NP 3.1 as it contains, unlike NP 3.0.1, some tweaks for better support of HTML5 Audio.

@KruyKaze
Copy link

I'm using 3.1 i deactivated flash and restarted. Still complains about not
having flash for music in the library and can't toggle html5 in google
music settings.
Arch 64
Thanks

On Wed, Mar 23, 2016 at 11:17 AM Jiří Janoušek [email protected]
wrote:

Thanks @jnv https://github.com/jnv. However, I'm particularly
interested in a feedback about NP 3.1 as it contains, unlike NP 3.0.1, some
tweaks for better support of HTML5 Audio.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#91 (comment)

@jiri-janousek
Copy link
Member Author

HTML5 Audio in Google Play Music works in Nuvola Player 3.1 in Ubuntu 14.04, 15.10 and 16.04, Debian Jessie and Fedora 23 with my account without All Access subscription. I'm going to check also Ubuntu 15.04, Fedora 22 and Arch Linux later and post here more details. Stay tuned :-)

@bartlibert
Copy link

Just confirming that HTML5 audio is not working with 3.1 in Debian Sid with All Access

@Celti
Copy link

Celti commented May 14, 2016

HTML5 audio also fails with git HEAD on Arch Linux with All Access. In fact, the HTML5 toggle is greyed out in every browser I have access to. HTML5 audio works fine in Chromium, even with all plugins disabled (Pepper Flash, Native Client, Widevine Content Decryptor), fails in Firefox.

@jiri-janousek jiri-janousek added this to the June 2016 milestone May 30, 2016
jiri-janousek added a commit that referenced this issue Jun 1, 2016
Some web sites may use user agent sniffing and it is necessary to
disguise as a different browser. For example, Google Play Music
& HTML5 Audio.

Issue: #91

Signed-off-by: Jiří Janoušek <[email protected]>
jiri-janousek added a commit that referenced this issue Jun 1, 2016
Some web browsers (e.g. Chrome) have them already unprefixed.
This may improve compatibility with Chrome-targeted websites,
e.g. Google Play Music.

Issue: #91

Signed-off-by: Jiří Janoušek <[email protected]>
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Jun 1, 2016
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Jun 1, 2016
It may be necessary to add workarounds

Issue: tiliado/nuvolaplayer#91

Signed-off-by: Jiří Janoušek <[email protected]>
jiri-janousek added a commit that referenced this issue Jun 3, 2016
InitWebWorker signal is going to be emitted after DOM document
is loaded and it's too late for unprefixing.

Issue: #91

Signed-off-by: Jiří Janoušek <[email protected]>
@jiri-janousek
Copy link
Member Author

❤️ Another Nuvola Patron is interested in this feature.

@jiri-janousek
Copy link
Member Author

Could you please attach a full log from flatpak run eu.tiliado.NuvolaAppGooglePlayMusic//master -D? There might be something helpful.

@excieve
Copy link

excieve commented Aug 14, 2017

Here it is:
nuvola_debug.txt

@jiri-janousek
Copy link
Member Author

It asks about audio/mp4; codecs="mp4a.40.2" :

CONSOLE LOG Audio.canPlayType: audio/mp4; codecs="mp4a.40.2" => probably;
  audio/mp4; codecs="mp4a.40.2" => probably
CONSOLE LOG audio/mp4; codecs="mp4a.40.2":
  MediaSource.isTypeSupported => true; Audio.canPlayType => probably;
  result => true

@excieve
Copy link

excieve commented Aug 15, 2017

Well, that's the only difference I can spot to separate playing and crashing songs. Please let me know if there's any way I can help debugging this.

@excieve
Copy link

excieve commented Aug 15, 2017

I've downloaded a first 4s chunk of the stream for one of the songs. I can test it with something minimal to check if that has to do with one of the components (such as WebKitGtk). Here's the related codec info of this chunk:

Stream #0:0(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 0 kb/s (default)

@jiri-janousek
Copy link
Member Author

I'll try to port Nuvola to use CEF instead of WebKitGTK. There should be no issues with MSE.

@jiri-janousek
Copy link
Member Author

Any volunteer to test the work-in-progress CEF backend with Google Play Music? Se also a draft of a blog post Status of Chromium-based Port of Nuvola.

@excieve
Copy link

excieve commented Dec 11, 2017

@fenryxo Great stuff! I'll be happy to test it soon.

@KruyKaze
Copy link

KruyKaze commented Dec 12, 2017 via email

@jiri-janousek
Copy link
Member Author

  1. Install the master branch of Nuvola Core Developer Kit, but skip any subsequent set-up instructions.
  2. Then run flatpak run --command=Cefium eu.tiliado.NuvolaCdk --disable-flash --url="https://play.google.com/music/"

@excieve
Copy link

excieve commented Dec 12, 2017

Works great for me! Although UI feels a little sluggish (no GPU acceleration?)
screenshot from 2017-12-12 14-03-54

@jiri-janousek
Copy link
Member Author

Although UI feels a little sluggish (no GPU acceleration?)

Reticketed as tiliado/valacef#1

@KruyKaze
Copy link

KruyKaze commented Dec 12, 2017 via email

@jiri-janousek
Copy link
Member Author

Runs here with no slowdown but I can't use multimedia hotkeys or nuvolactl

That's because it is not Nuvola but Cefium - a demo web browser to test ValaCEF functionality. Once ValaCEF is complete, it will be used by Nuvola instead of WebKitGTK.

jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Dec 26, 2017
@jiri-janousek
Copy link
Member Author

Blog post: Status of Chromium-based Port of Nuvola

@jiri-janousek
Copy link
Member Author

Users with Nuvola Basic/Premium/Patron account will be invited to test development builds soon.
-- Status of Chromium-based Port of Nuvola

All Nuvola Patron & Premium user have been invited to test Nuvola with working Chromium backend, Nuvola Basic users will follow in a week.

@KruyKaze
Copy link

KruyKaze commented Jan 7, 2018 via email

@jiri-janousek
Copy link
Member Author

Users with Nuvola Basic/Premium/Patron account will be invited to test development builds soon.
-- Status of Chromium-based Port of Nuvola

All Nuvola Patron & Premium user have been invited to test Nuvola with working Chromium backend, Nuvola Basic users will follow in a week.

Nuvola Basic users have also been invited.

@jiri-janousek jiri-janousek removed in progress need info Assignee needs more information to work on this ticket. labels Mar 31, 2018
@jiri-janousek
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants