Make the --scripts-version option work with tests. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using react-scripts-ts as the scripts version results in the test script failing due to "--scripts-version" being an unsupported option for the react-scripts-ts test script. Since that option is only of relevance to react-app-rewired, strip it out of the list of arguments before passing those on to the called test script.
Guria
approved these changes
Oct 5, 2017
Guria
reviewed
Oct 5, 2017
|
@Guria any further thoughts on this? If not let's merge it. |
|
Ah, sorry. Forgot about it. Let me check again. |
|
ok, nothing special. merging |
|
Thanks all - [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using react-scripts-ts as the scripts version results in the test script
failing due to "--scripts-version" being an unsupported option for the
react-scripts-ts test script.
Since that option is only of relevance to react-app-rewired, strip it out
of the list of arguments before passing those on to the called test script.