-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FURTHER DEVELPMENT of VIEW for everyone who stumbles upon this repository #51
Open
naixx
wants to merge
20
commits into
timelapseplus:master
Choose a base branch
from
naixx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.4 because of this
…iles, Faster intervalometer restart
Add additional logging Infrastructure for tests
Optimize setEv (set camera exposure values) in balance mode more optimized. If previous change in one direction was of the same parameter, then the opposite direction change will be of the same parameter. Except iso in up direction, we want it to ramp as quickly as possible. TODO make aperture changes not so quick as it is now, but scaled to the number of shutter changes Add some offline tests for setEv changes
…d build it on VIEW device
… take many frames to recover. Fix that. Introduce a new method to calculate day and night luminance references. Previously, if the image was slightly underexposed, your day/night reference luminance values could be incorrect, resulting in your reference photo being out of the range of reference values. Fix an issue with blending parameters.
… turn dial up or down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't hope that this PR will be merged since the development of VIEW has been abandoned. So it is basically for everyone who stumbles upon this repository. You can check my fork https://github.com/naixx/VIEW
Notable changes:
day
andnight
.sunrise ramping algorithm
. Previously, the algorithm sometimes hesitated to adjust to the increasing light levels in the mornings. It has been modified to ramp faster towards brighter conditions.S=A=I
). If previous change in one direction was of the same parameter, then the opposite direction change will be of the same parameter. Except iso in up direction, we want it to ramp as quickly as possible.For instance, transitioning to darkness with the previous algorithm:
6s 5.6f
,8s 5.6f
(s),8s 4f
(a),10s 4f
(s) -> transitioning light ->10s 5.6f
(a) -> transitioning dark ->12s 5.6f
(s). Notice that the shutter and aperture change sequentially, which can lead to a peculiar situation where you may end up with a longer shutter speed instead of a wider aperture at night.The new algorithm will maintain the adjusted parameter sequence:
6s 5.6f
,8s 5.6f
(s),8s 4f
(a),10s 4f
(s) -> transitioning light ->8s 4f
(s) -> transitioning dark ->10s 4f
(s). Notice that theaperture remains unchanged
as the EV decreases and increases.S=A=I
), ISO will consistently be the last parameter to change when transitioning to darker settings and the first parameter to adjust when transitioning to brighter settings.