Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET Core 3.0 #17

Closed
tintoy opened this issue Oct 10, 2019 · 13 comments
Closed

Upgrade to .NET Core 3.0 #17

tintoy opened this issue Oct 10, 2019 · 13 comments

Comments

@tintoy
Copy link
Owner

tintoy commented Oct 10, 2019

Now that 3.0 is out, we should upgrade the language server to target netcoreapp3.0.

This means consumers will need either the 3.0 SDK or the 3.0 runtime if they don’t want to upgrade to the 3.0 SDK yet.

May need to be careful about verifying that this doesn’t affect behaviour of the MSBuild engine at runtime.

@tintoy
Copy link
Owner Author

tintoy commented Oct 15, 2019

Should help with tintoy/msbuild-project-tools-vscode#42.

@tintoy
Copy link
Owner Author

tintoy commented Oct 31, 2019

https://github.com/tintoy/msbuild-project-tools-vscode/releases/tag/v0.3.1

Hi - @divinebovine @mateusdeap, are you able to try this new build to see if it works for you? It's now built against .NET Core 3.x.

@divinebovine
Copy link

@tintoy should it be showing up when I try to check for extension updates in vscode? Because it doesn't show up. Or do I need to install it by VSIX?

@tintoy
Copy link
Owner Author

tintoy commented Oct 31, 2019

By VSIX - I want to make sure it actually works for others before I publish it more widely :)

@tintoy
Copy link
Owner Author

tintoy commented Nov 2, 2019

In the meanwhile I'm going to try to enhance the extension as well so it can do a better job of reporting when the language server can't be launched.

tintoy added a commit that referenced this issue Nov 2, 2019
tintoy added a commit to tintoy/msbuild-project-tools-vscode that referenced this issue Nov 2, 2019
@tintoy
Copy link
Owner Author

tintoy commented Nov 3, 2019

Published v0.3.2 - the extension should now provide more useful information if the language server cannot be started.

@mateusdeap
Copy link

@tintoy Ok, so I tested the extension. Everything seems to be just fine. I just had one issue, but I'm unsure if it's a bug:
msbuild_test
If I just type the < character, it will give me the snippets, however it will just concatenate the snippet to the < I typed, as the image shows

@MeikTranel
Copy link

That's been an issue for quite some time now. Should be unrelated to .NET Core 3.0

@tintoy
Copy link
Owner Author

tintoy commented Jan 3, 2020

Sorry, this one has fallen off radar :)

I’ll look into it this afternoon...

@MeikTranel
Copy link

No worries mate. Just wanted let you know before you go yak shaving on .NET Core 3.0 for no reason 😄

@tintoy
Copy link
Owner Author

tintoy commented Jan 4, 2020

Here's what happens when I try to insert a <PackageReference> snippet:

Repro

(the only keys I press are <, then p, then a, then <enter>)

@tintoy
Copy link
Owner Author

tintoy commented Jan 4, 2020

That's on VSCode v1.39.2.

@mateusdeap
Copy link

Hmmm. I guess I'll check my VS Code version later and test it. Either way, I think this issue can be considered closed, since the upgrade has been done. Thanks a bunch! :D

@tintoy tintoy closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants