Add help links for well-known elements #5
Comments
(still need to hook this up to the hover content provider) tintoy/msbuild-project-tools-server#5
|
We can also have extension points so that Custom Sdks can have their own help files like for my Sdk I can include I will update those help files in my repo for specific files and my sdk and test them and I'll include a PR later, if you are okay with this idea! |
|
Sure! Might be worth investigating whether there's an "official" way to
package help for SDKs too? Or maybe we could add support for parsing XSDs
to extract from there?
…On Sat, 14 Apr. 2018, 6:02 pm Nirmal Guru, ***@***.***> wrote:
We can also have extension points so that Custom Sdks can have their own
help files
like for my Sdk I can include <My.Custom.Sdk>\Docs folder to include my
specific props/targets/tasks and for those Sdks that don't have their own
Docs folder within their Sdk, We can have one from the Community, like the
one you have for Common props and targets!
I will update those help files in my repo for specific files and my sdk
and test them and I'll include a PR later, if you are okay with this idea!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABkezIt_DSbzRS7o09OLtXqfAoY2Weboks5toa0qgaJpZM4TU6jq>
.
|
|
The NuGet team proposed having docs along-side lib and ref folder but they killed the feature in-favour of having docs within lib or ref folder! Now Sdks have becoming a thing I could ask NuGet team to include docs for Sdk packages, I will do that once my PoC works! |
|
CC: @Nirmal4G - the help links are working now; if I can build you a custom |
|
Yes, I'd be happy too! I'm already experimenting with help files coming from the SDKs! |
…wn MSBuild XML elements that don't directly correspond to MSBuild objects #5
|
You'll need to manually uninstall the existing extension and then install this one via the |
|
Element help is configured here. |
|
Ok, I installed it and the tools are successfully loading and logging in the window but I'm not getting any intellisense or hover contents!? |
|
Also getting this: |
|
Hmm, that's odd - sorry, roll back to the official release and I'll investigate in the meanwhile. |
|
Are you able to share the project XML where you saw this error? |
No Target element. Although now that you mention it, the same problem which was happening inside the project root element with SDK attribute defined (with a custom value), is happening inside the target element as well. Nice find! |
|
Thanks, will give it a try in an hour or so |
|
BTW, how are you overriding the msbuild extensions path? Via environment variable? |
|
Oops, you did already say how - sorry only just woke up about 15 mins ago :) |
|
BTW, have you seen this? https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-use-project-sdk |
|
@Nirmal4G - do you still get those errors if, instead of changing the |
|
BTW, I tried following your instructions above ( Sorry to be a pain, but is there any chance you could list an exact series of steps to replicate the issue? I just want to make sure we're doing exactly the same thing :) |
|
Oh, and while it's not implemented yet, tintoy/msbuild-project-tools-vscode#35 (comment) will make it a lot easier to override the extensions directory. |
No problem. you are helping me a lot with your extension, It's not at all a PAIN!
Since these are not released into public they are not in the NuGet or MyGet for the |
I like that feature. But could we make it generic by having any of the properties and env variables to override? |
|
Correct :) |
|
What about the steps to cause the error? Eg. Open file xxx, go to line a, column button, and hover the mouse pointer over it / type "<foo"... |
|
Column b, that is. Not column button (sorry, autocorrect). |
Sorry about that, I thought something else!
FYI You can edit comments on GitHub If you can't get it, I'll post a GIF tomorrow! |
|
Yeah, I'm on my phone and the mobile UI doesn't support editing comments unfortunately :) I'll give it a try shortly and let you know what I find tomorrow! |
|
Ah! Ok, I see the problem; the root element has no parent (of course), so that completion provider has issues; I'll fix that shortly. |
|
Ok - I've published a new release (v0.2.36) where that should be fixed (you can download and install the VSIX package manually for now; I haven't published it to the VS Marketplace yet. |
|
Trying it out! The Current Log: |
|
Hmm, that's interesting; it says it successfully loaded the first project (which is the "parent" referred to in the following errors), but subsequent project loads fail because they can't be matched up to the parent project (because although its XML could be parsed, the MSBuild engine failed to correctly load that XML). Can you try closing all projects and then opening one of the projects that fails? Does that work for you? |
|
Ok, I turned on verbose logging, and MSBuild can't load the Looks like MSBuild is failing to resolve the custom SDK (so the project won't load). BTW, here's how you turn on verbose logging:
|
|
(you only need to specify logging level, you can leave any other settings at their default values) |
|
Ok - the language service wasn't respecting any existing value for the |
|
I've tested this in v0.2.37 and your project loads correctly, now. |
|
Later, this hot-fix will be replaced by the functionality from #6. |
|
Thanks, I'll follow it up. Update: |
Includes elements such as
Import,ItemGroup,PropertyGroup, etc. Also includes well-known tasks.Relates to #4
The text was updated successfully, but these errors were encountered: