Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tab-character in completion text #13

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Feb 6, 2019

This makes the snippets work much nicer with indentations other than 4 spaces.

This makes the snippets work much nicer with indentations other than 4 spaces.
@tintoy
Copy link
Owner

tintoy commented Feb 6, 2019

Hi - thanks for contributing!

Will this change still work if spaces are being used? Sorry, not in front of my computer right now or I’d just check for myself :)

@inosik
Copy link
Contributor Author

inosik commented Feb 6, 2019

Yes, I usually use an indentation of 2 spaces in my MSBuild files and I already tried this locally:

2019-02-06_08-07-30

But this might also be some behavior which only VS Code has. I'm not sure how other editors would handle this.

@tintoy
Copy link
Owner

tintoy commented Feb 6, 2019

No worries, will add a setting for it :)

@tintoy
Copy link
Owner

tintoy commented Feb 6, 2019

(with default to tabs)

@inosik
Copy link
Contributor Author

inosik commented Mar 29, 2019

Hey, I wanted to check on this PR. Do you still plan to merge this? Can I do something to get this merged?

@tintoy
Copy link
Owner

tintoy commented Mar 29, 2019

Oh, sorry, I must have forgot about this! Doing it now :)

@tintoy tintoy merged commit 82ae5ac into tintoy:master Mar 29, 2019
@tintoy
Copy link
Owner

tintoy commented Mar 29, 2019

If I build and post a new vsix here, can you try it out for me?

@inosik
Copy link
Contributor Author

inosik commented Mar 29, 2019

Sure 👍🏻

@tintoy
Copy link
Owner

tintoy commented Mar 29, 2019

Ok, will build one in the next 10 mins or so :)

tintoy added a commit that referenced this pull request Mar 29, 2019
tintoy added a commit to tintoy/msbuild-project-tools-vscode that referenced this pull request Mar 29, 2019
@tintoy
Copy link
Owner

tintoy commented Mar 29, 2019

Sorry, took a bit longer than expected to build the new package (my NPM cache was broken). Here you go:

msbuild-project-tools-0.2.54.vsix.zip

@inosik
Copy link
Contributor Author

inosik commented Mar 30, 2019

Works like in the GIF above, thanks!

@tintoy
Copy link
Owner

tintoy commented Mar 30, 2019

Great - will publish the new release first thing in the morning :)

@inosik inosik deleted the improve-completions branch April 1, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants