Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions don't always work correctly in .props files #27

Closed
tintoy opened this issue Dec 23, 2017 · 1 comment
Closed

Completions don't always work correctly in .props files #27

tintoy opened this issue Dec 23, 2017 · 1 comment
Assignees
@tintoy
Labels
area/intellisense area/msbuild bug help wanted

Comments

@tintoy
Copy link
Owner

tintoy commented Dec 23, 2017

If a *.props file is opened without first having opened a *.*proj file, then completions don't work correctly. Work out why this is happening and fix it :)

(I suspect it's due to an assumption about project SDK somewhere in the the semantic model?)
@tintoy tintoy self-assigned this Dec 23, 2017
@tintoy
Copy link
Owner Author

tintoy commented Dec 23, 2017

Upgrading to latest LSP packages fixed this; turns out it was due to an issue in the matcher for document selectors.

tintoy added a commit that referenced this issue Dec 23, 2017
@tintoy
Bug-fix: Completions don't always work correctly in .props files.
d67219a 
#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tintoy tintoy

Labels
area/intellisense area/msbuild bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tintoy