Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented Change: Node 6 #285

Closed
futagoza opened this issue Mar 24, 2018 · 1 comment
Closed

Undocumented Change: Node 6 #285

futagoza opened this issue Mar 24, 2018 · 1 comment

Comments

@futagoza
Copy link
Contributor

The changelog does not mention at all that this module now requires Node.js v6

  1. Did you forget to add it, or did you think this wasn't required?
  2. Why did you set the minimum to Node.js v6?
This was referenced Mar 24, 2018
Closed
Merged
@tleunen
Copy link
Owner

tleunen commented Mar 24, 2018 •
edited
Loading

Bad move. Since Node v4 is still in LTS. We should definitely support it. And removing support should definitely be a breaking change (which was the case since node 6 was added in v3.0.0 if I recall correctly)

Thank you for creating the PR to add the support of node 4 back.

tleunen pushed a commit that referenced this issue Mar 24, 2018
@futagoza @tleunen
fix: Add support for Node 4 (#286)
2d5bf09 
Closes #285 
Fixes #236
amosyuen pushed a commit to amosyuen/babel-plugin-module-resolver that referenced this issue Jul 11, 2018
@futagoza @amosyuen
fix: Add support for Node 4 (tleunen#286)
1671ddb 
Closes tleunen#285 
Fixes tleunen#236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@futagoza @tleunen