Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key of alias to support using $ prefix #313

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Conversation

Telokis
Copy link
Contributor

@Telokis Telokis commented Aug 18, 2018

Closes #312

(See #312 for detailed explanation)

@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Copy link
Contributor

@fatfisz fatfisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, LGTM!

@fatfisz fatfisz merged commit 4c56684 into tleunen:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants