fix(prost-build): re-export error_message_protoc_not_found, protoc_from_env & protoc_include_from_env
#1063
Conversation
|
@gibbz00 |
|
Yup, let me yank v0.12.5, we didn't think this was going to cause an issue but clearly it does 😄 thanks for the report. |
|
It's been yanked, we will work on a follow up release that fixes these semver issues. |
prost-build/src/lib.rs
Outdated
| @@ -149,7 +149,7 @@ mod message_graph; | |||
| mod path; | |||
|
|
|||
| mod config; | |||
| pub use config::Config; | |||
| pub use config::{protoc_from_env, protoc_include_from_env, Config}; | |||
There was a problem hiding this comment.
We should restore all moved pub functions. This version will satisfy cargo-semver-checks:
| pub use config::{protoc_from_env, protoc_include_from_env, Config}; | |
| pub use config::{error_message_protoc_not_found, protoc_from_env, protoc_include_from_env, Config}; |
There was a problem hiding this comment.
Sorry, I accepted the change that broke your build. I was naive of me to assume this is an “internal” function and nobody is using it.
No worries. It was great to see it quickly yanked and sorted 🙌. Thanks for spending your time working on the crates I use :)
We should restore all moved pub functions. This version will satisfy cargo-semver-checks:
There was a problem hiding this comment.
No worries. It was great to see it quickly yanked and sorted 🙌. Thanks for spending your time working on the crates I use :)
Well, you created this PR half an hour after publish. So, I am impressed with that as well 😃
…_from_env` & `protoc_include_from_env` fixes: tokio-rs#1062 I'm adding to fix a breaking change introduced in tokio-rs#1020 which moved these items. Since `0.12.5` this is causing build failures after `cargo update`. ``` Compiling grpc-build v6.1.0 error[E0432]: unresolved imports `prost_build::protoc_from_env`, `prost_build::protoc_include_from_env` --> /Users/ethan.brierley/.cargo/registry/src/index.crates.io-6f17d22bba15001f/grpc-build-6.1.0/src/lib.rs:3:19 | 3 | use prost_build::{protoc_from_env, protoc_include_from_env, Module}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ no `protoc_include_from_env` in the root | | | no `protoc_from_env` in the root ```
eopb
changed the title
protoc_from_env & protoc_include_from_enverror_message_protoc_not_found, protoc_from_env & protoc_include_from_env
_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update fixes a regression: - fix(prost-build): re-export `error_message_protoc_not_found`, `protoc_from_env` & `protoc_include_from_env` (tokio-rs#1063)
_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update fixes a regression: - fix(prost-build): re-export `error_message_protoc_not_found`, `protoc_from_env` & `protoc_include_from_env` (#1063)
fixes: #1062
I'm adding this to fix a breaking change introduced in #1020 where these items were moved.
Since
0.12.5this is causing build failures aftercargo update.