-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed crt.sh parsing issue, -subs-only quirk and added support for riskiq #42
Open
cybercdh
wants to merge
25
commits into
tomnomnom:master
Choose a base branch
from
cybercdh:cybercdh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich caused issues with printing clean domains, also fixed issue where -subs-only didnt appear to work by moving the check outside of the main goroutine.
…to cybercdh yolo :q
b0156f1
to
a8bbc28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of return values from crt.sh
Sometimes the results from
crt.sh
will produce multiple results in thename_value
field, separated by a newline character. The whole returned string which may include multiple subdomains is treated as one subdomain and then passed tocleanDomain
which removes any erroneous prefixes.However, consider searching for subdomains of
yhs.search.yahoo.com
and this will yield, as an example,*.qa-release.yhs.search.yahoo.com\n*.qa-trunk.yhs.search.yahoo.com
which is of course two subdomains.Assetfinder will then output
thereby giving the appearance that
*.qa-trunk.yhs.search.yahoo.com
hasn't been passed throughcleanDomain
.I've updated the
crtsh.go
file to parse this field more effectively which ensures a "clean" output.-subs-only flag still producing non-subdomain results
I found that by moving the following substring comparison
outside of the main goroutine and into the for loop over the
out
range removed any erroneous results.