Unavailable videos comparisons list #1522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comparisonThumbnailComponent
…the error on a toggle bar when it is not compact and on an overlay on top of the entity picture when it is compact
Comment on lines
119
to
140
| <Box | ||
| display="flex" | ||
| justifyContent="center" | ||
| alignItems="center" | ||
| position="absolute" | ||
| top="0" | ||
| color="white" | ||
| bgcolor="rgba(0,0,0,.6)" | ||
| width="100%" | ||
| height="100%" | ||
| sx={{ | ||
| [theme.breakpoints.down('sm')]: { | ||
| fontSize: '0.6rem', | ||
| }, | ||
| }} | ||
| > | ||
| <Typography textAlign="center" fontSize="inherit"> | ||
| {entity.type == TypeEnum.VIDEO | ||
| ? t('video.notAvailableAnymore') | ||
| : t('entityCard.thisElementIsNotAvailable')} | ||
| </Typography> | ||
| </Box> |
There was a problem hiding this comment.
The same components are also used by <EntitySelectorInnerAuth>.
Let's factorize them in their own component.
GresilleSiffle
requested changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1070
This PR has for goal the display of unavailable entity on the comparisons list page.
The unavailable video must be highlighted with a message overlay on top of the image like for the comparison page