Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[back][front] feat: add a setting to control the weekly col. goal on mobile #1977

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

GresilleSiffle
Copy link
Collaborator

@GresilleSiffle GresilleSiffle commented May 30, 2024

Description

In the branch main the weekly collective goal is displayed by default on mobile. This widget takes up a lot of space, and reduce the space available for the sliders and the future comparison buttons. On some devices, the submit button is not visible without scrolling.

The comparison buttons, and the mobile UI in general, would greatly benefit from more space by default, especially when an entity context is displayed. This PR adds a new setting that controls the display of the weekly collective goal on mobile, and set the default value to false (not displayed on mobile devices). This way it's possible for a user to have the widget enabled on desktop, and disabled on mobile.

It should make the UI more simple and more friendly with new users.

before after
capture2 capture

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle self-assigned this May 30, 2024
@GresilleSiffle GresilleSiffle added Frontend Front-end code of Tournesol Backend Back-end code of Tournesol labels May 30, 2024
@GresilleSiffle GresilleSiffle added this to the Mobile Friendliness milestone May 30, 2024
@GresilleSiffle GresilleSiffle marked this pull request as ready for review May 30, 2024 08:53
@GresilleSiffle GresilleSiffle merged commit 2aa0470 into main Jun 6, 2024
8 checks passed
@GresilleSiffle GresilleSiffle deleted the add_setting_display_weekly_col_goal_on_mobile branch June 6, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Back-end code of Tournesol Frontend Front-end code of Tournesol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants