New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail .bashrc if travis is not installed #595

Merged

BanzaiMan merged 1 commit into travis-ci:master from lifeofguenter:do-not-fail-bashrc

Apr 24, 2020

Contributor

lifeofguenter commented May 4, 2018

Currently installing travis (bash completion) might add something like this into your .bashrc:

# added by travis gem
[ -f /Users/guenter/.travis/travis.sh ] && source /Users/guenter/.travis/travis.sh

This will unfortunately cause bash to spawn with a return-code of 1.

My fix will solve this issue and make sure that it will work if those files exist, and that it won't throw an error should they not exist:

    [ ! -s ~/.bashrc ] || echo yes; echo $? # file exists, outputs "yes", rc=0
yes
0
    [ ! -s ~/.bashrrc ] || echo yes; echo $? # file does not exist, outputs nothing, rc=0
0
    [ -s ~/.bashrc ] && echo yes; echo $? # file exists, outputs "yes", rc=0
yes
0
    [ -s ~/.bashrrc ] && echo yes; echo $? # file does not exist, outputs nothing, rc=1
1


          Do not fail .bashrc if travis is not installed

68dda75

BanzaiMan merged commit e6a6cbc into travis-ci:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet