Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mac builds #92

Closed
wants to merge 11 commits into from
Closed

[WIP] Mac builds #92

wants to merge 11 commits into from

Conversation

whophil
Copy link
Contributor

@whophil whophil commented Oct 29, 2021

Description

Using PR for testing / visibility.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@trelau
Copy link
Owner

trelau commented Oct 29, 2021

not sure if you'd had success locally, but i've noticed that when issues like show up in the binding generation process, pieces of bindings fail to generate successfully. seems like an include path or something is missing for osx maybe? https://github.com/trelau/pyOCCT/runs/4047559203?check_suite_focus=true#step:7:23

or maybe a compile flag is needed for osx somewhere?

# Clang compiler arguments ----------------------------------------------------

@whophil
Copy link
Contributor Author

whophil commented Nov 7, 2021

I am pausing my efforts on this, at least for a bit.

I can't correctly generate the bindings on Mac. The binding generation process needs to include type_traits, but even when I add the directory containing it to the includes, the binding process still fails with this type of error.

----------------------
DIAGNOSTIC INFORMATION
----------------------
---
SEVERITY: 4
LOCATION: <SourceLocation file '/Users/phil/anaconda3/envs/binder2/include/c++/v1/cstddef', line 44, column 15>
MESSAGE: 'stddef.h' file not found
---
Complete with 1 issues with lower than 4 severity not shown.

This doesn't cause the binding generation process to fail, it just results in incomplete bindings.

For my needs, I found that the OCP project already offers Win/Mac/Linux binaries, and for my project's needs it works the same.

@trelau
Copy link
Owner

trelau commented Nov 7, 2021

Thanks for the contributions @whophil . There is also pythonocc https://github.com/tpaviot/pythonocc-core which may be of use to you. It uses SWIG whereas pyOCCT (and I believe OCP) uses pybind11, but they all effectively do the same thing.

@whophil
Copy link
Contributor Author

whophil commented Nov 7, 2021

I did make a little more progress on the mac bindings. As the latest build log shows, these are now failing on a windows.h include, which I assume means some files need to be added to Mac excludes. I think this is more in line with (or will eventually lead to)
issues discussed in #19 , but at least the CI is showing some relevant errors.

@trelau
Copy link
Owner

trelau commented Nov 7, 2021

I cherry-picked some things from this PR and have been experimenting with this branch https://github.com/trelau/pyOCCT/tree/osx_support. It looks like there aren't anymore severe errors during the binding generation process, though not sure if everything if going to build and test successfully.

If you're working on osx locally, maybe you can try this branch?

@whophil whophil closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants