Remove old hack for Node 0.6 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 0.6 is no longer officially supported, and this questionable (comparing arrays containing numbers? .. how? :)) hack to get Node to play nice should probably no longer be a part of this codebase.
|
It'd be converting the array comparisons to strings. So |
|
Thanks! (FYI on the delay in my responding: #335 (comment)) |
trentm
pushed a commit
that referenced
this pull request
Jun 27, 2020
Co-authored-by: Ron Korving <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 0.6 is no longer officially supported, and this questionable (comparing arrays containing numbers? .. how? :)) hack to get Node to play nice should probably no longer be a part of this codebase.
If anyone can explain why this array-comparison thing worked in the first place, I'm fascinated to hear it :) What are the JS mechanisms here?