upgrade moment dependency because CVE-2017-18214 #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wait, looks like PR's of this already exist, oops, only looked through issues and could find anything... |
|
Thanks. I've merged effectively this change via #558 (FYI on the delay in my responding: #335 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github started to give me the following warning in my own repo:
Turned out that my dependency on bunyan, which has dependency on moment, caused this.
I know its listed as an optional dependency, and I assume its only used in the cli-code to display logs. So it probably only is a problem if someone starts editing log files and runs it through the cli or something. But nontheless, I dont think upgrading the dependency does any harm and it'll (hopefully) get rid of vulnerability warnings like the one I mentioned that is currently sitting on my github repo.
(The package-lock.json file is there because npm generated it for me, I figured I'd add it as well, since you're suppose to do that with package-lock.json files, but if you dont want it, or if that isnt aplicable to library projects, lemmy know and I'll take it out)