Use os.EOL for line endings for text loggers #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses `os.EOL` for line endings instead of `\n` This is useful for those of us using NodeJS on Windows where the easiest log reader is Notepad.exe Since the node runtime knows the platform, `os.EOL` is the most correct way to add a line ending to a text file Fixes trentm#589
|
Thanks! (FYI on the delay in my responding: #335 (comment)) |
trentm
pushed a commit
that referenced
this pull request
Jun 27, 2020
This change uses `os.EOL` for line endings instead of `\n` This is useful for those of us using NodeJS on Windows where the easiest log reader is Notepad.exe Fixes #589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
os.EOLfor line endings instead of\nThis is useful for those of us using NodeJS on Windows where the easiest log reader is Notepad.exe
Since the node runtime knows the platform,
os.EOLis the most correct way to add a line ending to a text fileFixes #589