-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality #4
base: master
Are you sure you want to change the base?
Conversation
macMikey
commented
Feb 25, 2019
- Properties to expand all nodes
- Function to return root folder
- Filter for file extensions
@macMikey Thanks for submitting enhancements. In order to keep PRs manageable, each PR should be for a specific feature addition or bug fix rather than combining a number of things into one. It makes it easier to review and provide feedback. If you can focus on one particular feature addition for this PR I would appreciate it. A couple of additional comments: Property to expand all nodes: the DataView Tree already has the Coding style: I need to put together a document that describes the coding style used in my repos. Some things to be aware of:
|
|
AFA the coding style, every time I work on something for levure I find myself going back and redoing at least some of it to get it into the form you prefer, so apologies that this will be a recurring issue. |
Regarding rendering twice - I can think of two approaches. One is don't have |
You can't just update that node, because you will lose the sort for the directory if the new name causes it to move in the sort order.
or |
Updating node after rename – Oh right. But you could just update the sibling nodes under the parent of the node that was renamed. That would be much more efficient. You can set the As I was thinking about the |
It probably would be. Much of what I was working on implementing was not API, it was functionality that I was adding. |
Yes, rename is the simpler of the two, but for a move, you have a bigger can of worms, depending on where the file is relocated. |