Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bar-assistant): Adding chart Bar Assistant #22741

Closed
wants to merge 24 commits into from

Conversation

KickingAss2024
Copy link
Contributor

@KickingAss2024 KickingAss2024 commented Jun 1, 2024

…lient

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@alfi0812 alfi0812 changed the title Adding chart Bar Assistant as an API server and Salt Rim as its web c… feat(bar-assistant): Adding chart Bar Assistant as an API server and Salt Rim as its web c… Jun 1, 2024
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
@alfi0812
Copy link
Collaborator

alfi0812 commented Jun 1, 2024

Also make sure to check the checklist in your initial post. And select the corresponding options. And name the pr correctly next time. (i made those changes for you).
But in general for a first. A pretty good start.

@PrivatePuffin PrivatePuffin changed the title feat(bar-assistant): Adding chart Bar Assistant as an API server and Salt Rim as its web c… feat(bar-assistant): Adding chart Bar Assistant Jun 1, 2024
charts/incubator/bar-assistant/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
@alfi0812 alfi0812 self-requested a review June 5, 2024 12:08
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@alfi0812 alfi0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if we can get this to work without nginx

charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
charts/incubator/bar-assistant/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: alfi0812 <[email protected]>
Signed-off-by: alfi0812 <[email protected]>
@alfi0812
Copy link
Collaborator

Closing as it would require Passwordless Redis and this isnt supported by our common right now.
So requires either upstream or common changes

@alfi0812 alfi0812 closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants