Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crafty-4): Update values.yaml #23403

Closed
wants to merge 1 commit into from

Conversation

lucasyoboy
Copy link

@lucasyoboy lucasyoboy commented Jun 15, 2024

Changed https to http

Description
Bad protocol.
⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Changed https to http

Signed-off-by: Lucas <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alfi0812 alfi0812 changed the title Update values.yaml fix(crafty-4): Update values.yaml Jun 15, 2024
Copy link
Collaborator

@alfi0812 alfi0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the chart version bump for your changes. Also can you explain why this change is needed?

@lucasyoboy
Copy link
Author

I was working with a Cloudflare tunnel, but for some reason, Cloudflare refused to accept the HTTPS certificate. So, I attempted to use the HTTP port, but the protocol wasn't correct.

@PrivatePuffin
Copy link
Member

I was working with a Cloudflare tunnel, but for some reason, Cloudflare refused to accept the HTTPS certificate. So, I attempted to use the HTTP port, but the protocol wasn't correct.

Thats not a good reason, does it work locally or not?
We don't care about whatever services you put in front of it, besides ingress.

Generally for https ingress should always be used.

@alfi0812
Copy link
Collaborator

Seems to work fine for me with https. Closing

@alfi0812 alfi0812 closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants