New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use `unref()` to allow graceful shutdown #26

Merged

huytool157 merged 2 commits into tryretool:main from KATT:feat/unref

Mar 19, 2024

Contributor

KATT commented Mar 18, 2024 •

edited

Loading

Closes #23 but an explicit stop would still be nice along side this

When called, the active Timeout object will not require the Node.js event loop to remain active. If there is no other activity keeping the event loop running, the process may exit before the Timeout object's callback is invoked. Calling timeout.unref() multiple times will have no effect.

— https://nodejs.org/api/timers.html#timeoutunref


          fix: use unref() to allow graceful shutdown

588d96f

huytool157 approved these changes

View reviewed changes


          Merge branch 'main' into feat/unref

huytool157 merged commit e122a52 into tryretool:main

2 checks passed

KATT deleted the feat/unref branch

May 27, 2024 10:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet