chore: Build update #454
Open
chore: Build update #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2020 16:46
Use a relative path devDependency on antlr4ts-cli, that's cleaner. Add steps to cleanup any npm global mess made before. Added 'npm run reinstall' script for clean-up of truly ugly problems. Note: reinstall involves a 'git purge -idx'. It asks permission...
Workaround for #458
added 4 commits
April 15, 2020 16:15
Disentangle imports / directory reorg Makes antlr4ts more like the other ANTLR4 target directory structure Build process now split out for packages, with each getting it's own package.json, and tsconfig.json. Eliminate relative path imports anywhere outside the src/ directory. checking in .d.ts files to track any api changes
Note: currently TypeScript v3.x is problematic in this context, but 2.9 is OK
|
run-s can really simplify your npm scripts |
|
Thanks @viceice, it looks nice. I'll look into incorporating it into a larger |
Implements suggestion in PR #454
|
Yes, I use it a lot, |
added 9 commits
April 16, 2020 14:53
Version 3.8.3 generates errors that don't seem right, so 3.7.5 it is. Getting to V3.x gets us the new project build mode, which is a big win in terms of build time. tsc will use tsconfig.tsbuildinfo files to manage an incremental compile which can really speed up many situations. Switches used on tsc commands change for this mode. One copy of the compiler, set in --watch mode, and watch the entire directory tree, performing compiles on change even if different parts of the tree uses different settings. Making this work right requires a change in import statments. None of them should ever reference the "src" directory, if needed use "dist" instead.
…sitory To run antlr, we use the `lerna run antlr` command. Any package that has an antlr script is run, lerna controls the ordering based on dependencies declared in the package.json files. The typescript compiler has multi-package build-in (in V3+). Combined with a new incremetal compile feature, this is a big time savings.
Fixes: #459 Yet more fixes for tslint gripes
BurtHarris
moved this from Done
to In Progress
in Update build tools and directory structure
added 5 commits
April 18, 2020 22:24
added 27 commits
April 30, 2020 11:03
Note: currently TypeScript v3.x is problematic in this context, but 2.9 is OK
Disentangle imports / directory reorg Makes antlr4ts more like the other ANTLR4 target directory structure Build process now split out for packages, with each getting it's own package.json, and tsconfig.json. Eliminate relative path imports anywhere outside the src/ directory. checking in .d.ts files to track any api changes
Implements suggestion in PR #454
Version 3.8.3 generates errors that don't seem right, so 3.7.5 it is. Getting to V3.x gets us the new project build mode, which is a big win in terms of build time. tsc will use tsconfig.tsbuildinfo files to manage an incremental compile which can really speed up many situations. Switches used on tsc commands change for this mode. One copy of the compiler, set in --watch mode, and watch the entire directory tree, performing compiles on change even if different parts of the tree uses different settings. Making this work right requires a change in import statments. None of them should ever reference the "src" directory, if needed use "dist" instead.
…sitory To run antlr, we use the `lerna run antlr` command. Any package that has an antlr script is run, lerna controls the ordering based on dependencies declared in the package.json files. The typescript compiler has multi-package build-in (in V3+). Combined with a new incremetal compile feature, this is a big time savings.
Fixes: #459 Yet more fixes for tslint gripes
…e pdd (describe()/it()) style test ui
internal.ts becomes the single controlling point for module load order fixes: #466
…into build_update
|
Rebase in PR #469 (dependabot jquery bump). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
npm linkfrom the build process.This command was leaving the development version of antlr4ts installed in the npm "global" space, which could get messy. This PR cleans up from the messy situation, and prevents it from occurring again.