Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass Number Precision with node-sass (libsass) #821

Closed
eddiegroves opened this issue Jan 15, 2015 · 1 comment
Closed

Sass Number Precision with node-sass (libsass) #821

eddiegroves opened this issue Jan 15, 2015 · 1 comment
Labels
Milestone

Comments

@eddiegroves
Copy link

I'm using node-sass and configured precision to 10. Example of compiled sass:

.col-xs-1 {
  width: 8.3333333333%;
}

However when comparing this to the standard bootstrap.css it has less precision (8):

.col-xs-1 {
  width: 8.33333333%;
}

Should I just use 8 as the precision with node-sass?

@eddiegroves eddiegroves changed the title Sass Number Precision Sass Number Precision with node-sass (libsass) Jan 15, 2015
@glebm glebm added the docs label Jan 15, 2015
@glebm glebm added this to the v3.3.2 milestone Jan 15, 2015
@glebm
Copy link
Member

glebm commented Jan 15, 2015

Yes, 8 should be OK. Good catch. We erred on the side of caution here, but since it's not causing issues for the upstream, bootstrap-sass should specify 8 as well.

glebm added a commit that referenced this issue Jan 17, 2015
@glebm glebm closed this as completed Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants