Use vanilla npm shrinkwrap instead of uber/npm-shrinkwrap #19604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is irrelevant and due to Medium/phantomjs#509 |
cvrebert
added a commit
that referenced
this pull request
Mar 24, 2016
Ports #19604 to v3. Special thanks to @kikinteractive, @azer, and @npm.
This was referenced Mar 24, 2016
|
We could just use shell.js which we already have as a dependency, I didn't get a CC otherwise I would have done this that way... |
chiraggmodi
pushed a commit
to chiraggmodi/bootstrap
that referenced
this pull request
Apr 8, 2019
…#18559 Ports twbs#19604 to v3. Special thanks to @kikinteractive, @azer, and @npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18559.
(Yes, I'm aware
mvdoesn't work in Windows. This is the least-worst option vs. adding more dependencies, at least until https://github.com/shelljs/shx has a proper release. This only affects the twbs team, not our users. If you absolutely need to run this on Windows, setup an mv=move alias in cmd.)Note to twbs team: You'll need to
npm uninstall npm-shrinkwrapor nukenode_modules/to eradicate your localuber/npm-shrinkwrapand be able to shrinkwrap properly going forward.