Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sass variable for accordion color #37182

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 20, 2022

Fixes #37144

This needs a bigger solve in v5.3 and v6 I think. Makes me want to move to an SVG sprite for all our images so that we have more control over color and can use CSS variables + inheritance to properly color and style these items. Also solves the CSP issues folks have with embedded SVGs. But, that's for another time.

@mdo mdo requested a review from a team as a code owner September 20, 2022 13:29
@julien-deramond julien-deramond merged commit 37e2e7e into main Sep 21, 2022
@julien-deramond julien-deramond deleted the accordion-color-again branch September 21, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Invalid interpolation of bs-body-color variable in bs-accordion-btn-icon url value
2 participants