Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate css variable #37257

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove duplicate css variable #37257

merged 1 commit into from
Oct 4, 2022

Conversation

nkdas91
Copy link
Contributor

@nkdas91 nkdas91 commented Oct 4, 2022

--#{$prefix}offcanvas-zindex: #{$zindex-offcanvas}; is already declared in line: 5 and should be removed from line: 15

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@nkdas91 nkdas91 requested a review from a team as a code owner October 4, 2022 11:23
julien-deramond
julien-deramond approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @nkdas91!

@julien-deramond julien-deramond merged commit 5975ca6 into twbs:main Oct 4, 2022
@nkdas91 nkdas91 deleted the patch-1 branch October 4, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkdas91 @julien-deramond