Accessibility: Minor fixes #37616
Merged
Accessibility: Minor fixes #37616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesheffer
reviewed
Dec 10, 2022
patrickhlauke
approved these changes
Jan 1, 2023
|
Hey @louismaximepiton. Could you please resolve the conflicts so that the PR can be merged :) |
|
Fixed the merge conflicts for you @louismaximepiton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some missing
aria-labelon toggler buttons.Add an
aria-hiddento the<div>wrapping content outside anyrole/hide an input that doesn't have any<label>.Motivation & Context
Raises some errors with
aXe devtools.Type of changes
Checklist
npm run lint)Live previews
Related issues
NA