Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack build to webpack guide #37796

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add webpack build to webpack guide #37796

merged 1 commit into from
Jan 4, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 3, 2023

Description

This PR suggests to enhance the Webpack guide with some references to webpack build / npm run build which is mentioned in the last sections.

It also adds some consistency with https://github.com/twbs/examples/tree/main/webpack project and is linked to twbs/examples#28.

Note: I've reintroduced here the comments from https://github.com/twbs/examples/blob/main/webpack/webpack.config.js but maybe we can just drop them in this file and revert my modification with the comments.

Question: Do we need to add a build command for Vite and Parcel as well?

Type of changes

  • Enhancement

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #37793

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo merged commit 8546804 into main Jan 4, 2023
@mdo mdo deleted the main-jd-fix-webpack-guide branch January 4, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

npm script: "build" missing on Bootstrap & Webpack doc
2 participants