Remove autofocus on theme switch when page is loaded #37836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-fix-autofocus-on-theme-switch
branch
from
5f27dbd
to
8c29620
Compare
|
/cc @patrickhlauke since I think he recently made some changes here |
|
oops. my bad @julien-deramond ... missed the fact this triggers on page load already. this PR fixes the issue nicely. |
patrickhlauke
approved these changes
Jan 8, 2023
krzysdz
added a commit
to krzysdz/inz
that referenced
this pull request
Jan 16, 2023
This commit mirrors twbs/bootstrap#37780 with ~~a small fix~~ a fix from twbs/bootstrap#37836 and adds the missing checkmark icon to the theme dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #37780, when our docs website is loaded, the theme switch gets automatically the focus which causes an issue of a11y since we can't go directly on the skip links.
I suppose that this modification was rather made to only give back the focus to the dropdown when a change is made and not during the init phase.
In order to understand what I'm saying, simply load https://twbs-bootstrap.netlify.app/. The focus (blue outline difficult to see) is automatically on the dropdown, then press Tab; "New in v5.3" will be focused instead of the skip links.
I tried to isolate the init phase in the script to force the focus only after. Please double-check that the a11y modifications made in the previous PR are still OK but it seems so.
Type of changes
Checklist
npm run lint)Live previews