Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix focus ring being cut off in table of contents #37965

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 28, 2023

Potential alternative to #37940.

/cc @patrickhlauke

@mdo mdo requested a review from a team as a code owner January 28, 2023 08:18
@patrickhlauke
Copy link
Member

This also works, sure. I wasn't sure whether not having the little left-hand border on the active item on medium size was intentional or not, so my approach kept that behaviour (hence the need for the media queries). This is obviously much more straightforward, and keeps the left-hand border at medium, large, and extra large sizes

@mdo mdo merged commit 9dd42e1 into main Feb 14, 2023
@mdo mdo deleted the toc-focus branch February 14, 2023 16:58
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants