unify offcanvas
keydown
event logic with modal
#38025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
offcanvas
keydown
event listener behaves like themodal
keydown
listener, the former was refactored like themodal
. Making it more readable by using positive conditions instead of negative ones.Motivation & Context
To make refactor and bugfix separated, a new PR was opened as discussed in this comment.
Type of changes
Checklist
npm run lint
)Live previews
N/A
Related issues
Splited from #37968