Drop unused --bs-focus-ring-box-shadow and add documentation for --bs-focus-ring-{x|y|blur}
#38095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-bs-focus-ring-{x|y|blur}`
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests removing
--bs-focus-ring-box-shadowwhich isn't used in the code. It might be considered a read-only custom property but IMHO, it can be misunderstood to have read-only custom properties. Or we could decide at some point to name them differently so that they can be more understandable by Bootstrap users.This PR also suggests documenting the presence of
--bs-focus-ring-x,--bs-focus-ring-y, and--bs-focus-ring-blurby providing an explanation and an example.Type of changes
Checklist
npm run lint)Live previews