Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Better scroll #38199

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Docs: Better scroll #38199

merged 1 commit into from
Mar 10, 2023

Conversation

louismaximepiton
Copy link
Member

Description

Removing :focus.
Removing * and replacing it by more specific selector.
Adding a scroll-margin-bottom.

Motivation & Context

Didn't work on FF.
Performance issue using the universal selector.
Avoid sticking to the very bottom of the page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@louismaximepiton louismaximepiton requested a review from a team as a code owner March 8, 2023 14:04
@louismaximepiton louismaximepiton mentioned this pull request Mar 8, 2023
Merged
21 tasks
@mdo mdo merged commit 1f7e7eb into main Mar 10, 2023
@mdo mdo deleted the main-lmp-better-docs-focus branch March 10, 2023 17:15
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@rawanst rawanst mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@jelenaCleo jelenaCleo mentioned this pull request Jul 17, 2024
Open
@cgeconomou cgeconomou mentioned this pull request Jul 17, 2024
Open
@FitriNurindahsari FitriNurindahsari mentioned this pull request Jul 17, 2024
Open
@mraible mraible mentioned this pull request Jul 17, 2024
Open
@kallyas kallyas mentioned this pull request Jul 20, 2024
Merged
@Acekueen Acekueen mentioned this pull request Jul 24, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Jul 24, 2024
Open
@scudette scudette mentioned this pull request Jul 28, 2024
Closed
@sanjayrajesh sanjayrajesh mentioned this pull request Aug 1, 2024
Open
@Ruzzel-bcremit Ruzzel-bcremit mentioned this pull request Aug 1, 2024
Open
@GTVolk GTVolk mentioned this pull request Aug 2, 2024
Open
@StefanMichielse StefanMichielse mentioned this pull request Aug 3, 2024
Open
@shivam-ivam shivam-ivam mentioned this pull request Aug 8, 2024
Open
@adarshaketh adarshaketh mentioned this pull request Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Aug 12, 2024
Closed
Closed
@acharya-deepak acharya-deepak mentioned this pull request Aug 17, 2024
Open
@AmimerNabil AmimerNabil mentioned this pull request Aug 18, 2024
Merged
@soelshaikh soelshaikh mentioned this pull request Aug 18, 2024
Open
This was referenced Aug 26, 2024
Open
Open
Open
@tchellam tchellam mentioned this pull request Aug 27, 2024
Open
@PholSoophak PholSoophak mentioned this pull request Aug 29, 2024
Open
@csmartinez22 csmartinez22 mentioned this pull request Aug 30, 2024
Open
@ungtsuhan ungtsuhan mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 3, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs enhancement v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louismaximepiton @mdo