Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: fix 'Events' JS example #38554

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 4, 2023

Description

This PR changes the "Events' JS example showing how to use show.bs.modal and event.preventDefault().

My proposal here is to simply remove the if (!data) condition which can be difficult to understand for readers because data doesn't exist. Certainly, the example is not very useful except for being informative. Maybe you have other ideas here :)

Type of changes

  • Doc change (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38552

@XhmikosR XhmikosR requested a review from GeoSot May 17, 2023 04:22
@mdo mdo merged commit 9129e4a into main Jun 1, 2023
@mdo mdo deleted the main-jd-drop-data-test-in-js-events-example branch June 1, 2023 02:32
@XhmikosR XhmikosR removed the js label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Not declared variable
3 participants