Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .table-light from table foot example #39320

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 21, 2023

Description

As mentioned in #39319, users could expect to see .table-light in the code part. Since this part is rather to show the table foot, I've dropped the .table-light class from the rendering part. It makes it consistent with the other examples and doesn't "pollute" the code part with an extra class.

Type of changes

  • Doc enhancement (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39319

@julien-deramond julien-deramond marked this pull request as ready for review October 21, 2023 10:51
@julien-deramond julien-deramond merged commit d58e86e into main Oct 23, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-table-foot-code-example branch October 23, 2023 17:21
priyashpatil pushed a commit to priyashpatil/bootstrap that referenced this pull request Nov 8, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Table foot - Incorrect documentation
2 participants