Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type-hints to the LoopContext constructor #4168

Merged
merged 1 commit into from
Jul 31, 2024
Merged

add type-hints to the LoopContext constructor #4168

merged 1 commit into from
Jul 31, 2024

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Jul 30, 2024 •
edited
Loading

@xabbuh xabbuh mentioned this pull request Jul 30, 2024
Merged
@stof
Copy link
Member

stof commented Jul 31, 2024 •
edited
Loading

should __invoke be typed as iterable or no ?

@xabbuh
Copy link
Contributor Author

xabbuh commented Jul 31, 2024

@stof makes sense I guess

@fabpot
Copy link
Contributor

fabpot commented Jul 31, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 96b11f7 into twigphp:4.x Jul 31, 2024
30 of 31 checks passed
@xabbuh xabbuh deleted the pr-4153 branch July 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xabbuh @stof @fabpot