Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] generated esm has invalid reference to map files #103

Closed
waynebrantley opened this issue Aug 5, 2022 · 7 comments
Closed

[BUG] generated esm has invalid reference to map files #103

waynebrantley opened this issue Aug 5, 2022 · 7 comments
Labels
bug Something isn't working needs more info

Comments

@waynebrantley
Copy link

  • [ x] I have verified that the issue occurs with the latest twilio.js release and is not marked as a known issue in the CHANGELOG.md.
  • [ x] I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • [ x] I verified that the Quickstart application works in my environment.
  • [ x] I am not sharing any Personally Identifiable Information (PII)
    or sensitive account information (API keys, credentials, etc.) when reporting this issue.

The following files reference a map file that does not exist, which causes warnings when building (and of course keep the map files from working).

AudioPlayer.js
Deferred.js
EventTarget.js

Suggest to include the map file in the package or remove the map reference

Here is a screenshot showing the reference and what files are shipped.

image

@waynebrantley waynebrantley added the bug Something isn't working label Aug 5, 2022
@k-funk
Copy link

k-funk commented Aug 24, 2022

+1

This is blocking my project from upgrading some of our infrastructure. (webpack/create-react-app)

@charliesantos
Copy link
Collaborator

Submitted an internal ticket. Tracking this as part of #147

@charliesantos
Copy link
Collaborator

@waynebrantley can you please try this RC version? #55 (comment)
We're able to see source maps now properly in our svelte+vite and angular 16 projects.

@charliesantos
Copy link
Collaborator

SDK source maps work but the AudioPlayer source maps, which is a dependency, are still missing. We will be addressing them soon. Please stay tuned!

@waynebrantley
Copy link
Author

waynebrantley commented Jun 16, 2023

@charliesantos I did a test of the build.
I am happy to report I did not get any errors in building regarding map files.
I noticed a 20k decrease in bundle size which I will report on the other ticket.
(really be nice if this was even more of a decrease)

@charliesantos
Copy link
Collaborator

Fixed in 2.6.0-rc2

@charliesantos
Copy link
Collaborator

We just released 2.6.0 which contains the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info
Projects
None yet
Development

No branches or pull requests

3 participants