-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio Voice sdk not supporting webpack > 5 #79
Comments
Hi @Rkkk16, As this repo is for the Video SDK, I'll transfer your issue to the Voice SDK. Best, |
Hi @Rkkk16 , this issue should be fixed with the latest Voice SDK version. Thanks! |
Can this issue be re-opened? There's more to supporting webpack 5 than just the engine.
More importantly (since it creates warnings in my dev server), it seems like the installed files include a reference to a sourcemap that is not actually present. The
|
bump. please re-open, or let me know if i should open a new issue |
@k-funk can you please reopen a new issue and provide all details? |
I've updated from webpack 4 to 5 and I was using twilio/voice-sdk version 2.7.1 it seems twilio uses querystirng, which is not supported in webpack 5 how to handle this? |
@KlentyDhanush thanks for reaching out! Can you please submit a new issue and provide more details? Which query string? Any error messages you can share? Etc |
@charliesantos thank you for the response, I found a work around to fix the issue. TypeError: qs.escape is not a function In ClientCapability.js file, var qs = require('querystring'); as webpack 5 doesn't have nodejs modules querystring won't work so used querystring-browser as alias for querystring in the webpack config file. |
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@twilio/[email protected]',
npm WARN EBADENGINE required: { node: '12' },
npm WARN EBADENGINE current: { node: 'v16.13.1', npm: '8.3.0' }
npm WARN EBADENGINE }
The text was updated successfully, but these errors were encountered: