Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typings URL: https://github.com/types/npm-co
Questions (for new typings):
index.js
<->index.d.ts
)?Change Summary (for existing typings):
If anyone is interested, it's a pretty decent demonstration of TypeScript generics and how to unravel a type (E.g using
<T> (arg: Promise<T> | T): Promise<T>
to unravel promises and other types - in this case, thunks, iterables, etc). However, the type definition itself isn't very effective because of the limitations on generator functions in TypeScript. It appears the return type isn't even considered. Also, yielded values can't get any types either - they are alwaysany
and the input toIterableIterators
is also alwaysany
./cc @mhegazy am I using the generators correctly? Is it possible to use the return type only or otherwise specify the result of
yield
s?