Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power of 2 for all quadtrees #44

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

tzaeschke
Copy link
Owner

@tzaeschke tzaeschke commented Jul 31, 2024

Use the power-of-2 approach (Issue #42 and PR #43) for all quadtree type indexes.
This approach immensely reduces precision errors.

@tzaeschke tzaeschke self-assigned this Jul 31, 2024
@tzaeschke tzaeschke force-pushed the fix/42-root-resizing-part-2 branch from 0cf38d2 to 6c3bdeb Compare July 31, 2024 13:01
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 23.45679% with 62 lines in your changes missing coverage. Please review.

Project coverage is 74.73%. Comparing base (fc9e7fd) to head (d6c239d).
Report is 3 commits behind head on master.

Files Patch % Lines
...in/java/org/tinspin/index/qtplain/QuadTreeKD0.java 40.90% 10 Missing and 3 partials ⚠️
...java/org/tinspin/index/qthypercube/QuadTreeKD.java 40.00% 8 Missing and 1 partial ⚠️
...ava/org/tinspin/index/qthypercube/QuadTreeRKD.java 25.00% 9 Missing ⚠️
...n/java/org/tinspin/index/qtplain/QuadTreeRKD0.java 0.00% 9 Missing ⚠️
...va/org/tinspin/index/qthypercube2/QuadTreeKD2.java 11.11% 8 Missing ⚠️
...rc/main/java/org/tinspin/index/util/MathTools.java 0.00% 4 Missing ⚠️
src/main/java/org/tinspin/index/PointMap.java 0.00% 3 Missing ⚠️
src/main/java/org/tinspin/index/PointMultimap.java 0.00% 3 Missing ⚠️
src/main/java/org/tinspin/index/BoxMap.java 0.00% 2 Missing ⚠️
src/main/java/org/tinspin/index/BoxMultimap.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     74.77%   74.73%   -0.05%     
- Complexity     2084     2118      +34     
============================================
  Files            76       77       +1     
  Lines          8061     8156      +95     
  Branches       1576     1593      +17     
============================================
+ Hits           6028     6095      +67     
- Misses         1644     1660      +16     
- Partials        389      401      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 7ef1133 into master Jul 31, 2024
1 of 3 checks passed
@tzaeschke tzaeschke deleted the fix/42-root-resizing-part-2 branch July 31, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant