Would my filter list be a good feature for uBlock Origin and its community?

[Incrypters]

Hello,

I have curated a list of 2000+ scam videos and channels that spread malware on youtube in my github repo. I was wondering if it was possible to add it to one of the filter lists as a custom import list would not block these links to the scam videos and channels.

The repo is here

Thank you and have a nice day!

[garry-ut99]

as a custom import list would not block these links to the scam videos and channels.

Works with $doc or $all, example:

||youtube.com/channel/UCK5Es63vf6gAgflsR2Ase5Q^$all
||youtube.com/watch?v=VtSEHB5XEMg^$all

Documentation:
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#document
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#all

[garry-ut99]

What are you going to block?

I tried wildcards because:

• a) videos were sometimes still playing when clicking at video thumbnails on the right (and they still do, even with a wildcard applied, so it seems that idea with adding wildcard didn't work to resolve this issue)
• b) wildcard blocks also video thumbnails, and not only video, which is desired and useful, because if the purpose is to block fake/scam videos, then blocking theirs thumbnails is desired as well

Your filters:

• still "don't block videos when clicking at video thumbnails on the right" either (a)
• and additionaly leak video thumbnails (b)

Better to add individual rules like you originally said

but I do agree that if a single wildcard still does make a difference in terms of performance, then it's better to split them to more efficient specific wildcard-less counterparts.

[stephenhawk8054]

Video/channel ID (whether with wildcard or not) won't help when users click on videos inside youtube page, because when you do that, it generates ?prettyPrint XHR POST connections and sends the ID via Request body. You might need something like

youtube.com##+js(trusted-replace-fetch-response, /.+?videoId":"(?:nwoCoj4j14g|VtSEHB5XEMg)".+/, , /player?)

but it can only prevent the video from loading and cannot block the page, maybe combining it with something like

youtube.com##ytd-watch-flexy:is([video-id="nwoCoj4j14g"],[video-id="VtSEHB5XEMg"]):remove()

will help

[garry-ut99]

The scriptlet works fine.

The cosmetic filter without :remove() works fine as well.

But :remove() part causes the cosmetic filter malfunctions sometimes:

• sometimes doesn't work
• sometimes does work, but after pressing "back" arrow in browser, the previous video loads fine (can hear the sound), but the cosmetic filter still hides the whole page

All the problems are gone after removing :remove() part, but curious why you added :remove(), and whether any problems will appear without it.

[stephenhawk8054]

Just wanted to remove the node, but if it causes issue, yeah you can remove it.

Anyways, what I mean is currently there's no ways to do it via network filters alone and you'll need more complicated approach for this issue.

[garry-ut99]

Ok, I'm just trying to help OP, hence the final example, for a single video:

||youtube.com/channel/UCK5Es63vf6gAgflsR2Ase5Q$all,domain=youtube.com
||youtube.com/watch?v=VtSEHB5XEMg$all,domain=youtube.com
||i.ytimg.com/vi/VtSEHB5XEMg$image,domain=youtube.com
youtube.com##ytd-compact-video-renderer:has([href="/watch?v=VtSEHB5XEMg"])
youtube.com##ytd-compact-radio-renderer:has([href^="/watch?v=VtSEHB5XEMg"])
youtube.com##+js(trusted-replace-fetch-response, /.+?videoId":"(?:VtSEHB5XEMg|SomeOtherVideoID)".+/, , /player?)
youtube.com##ytd-watch-flexy:is([video-id="VtSEHB5XEMg"],[video-id="SomeOtherVideoID"])

It still might be not complete because maybe need more network/cosmetic filters needed to hide all thumbnails (for ex. on main search page).

Also I'm not sure about this one: youtube.com##ytd-compact-radio-renderer:has([href^="/watch?v=VtSEHB5XEMg"]) as this thumbnail leads to a video but at the same time to a video playlist compilation.

Personally I use BlockTube extension to block unwanted videos and channels:

• https://chromewebstore.google.com/detail/blocktube/bbeaicapbccfllodepmimpkgecanonai
• https://addons.mozilla.org/en-CA/firefox/addon/blocktube/

[gwarser]

Commit history is short. Promote, maintain, build user base.

[garry-ut99]

I agree.

[Yuki2718]

And why ^ at the end of all rules? Read documentation.