-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostname exclusion not working with importScripts()
#114
Comments
When looking at Network pane in dev tools, what is the "Initiator" when the script if fetched by the browser? |
What I am wondering is whether the domain of the initiator matches your "No filtering" entry. |
uBOL uses const rule = {
id: TRUSTED_DIRECTIVE_BASE_RULE_ID,
action: { type: 'allowAllRequests' },
condition: {
requestDomains: [ ... ],
resourceTypes: [ 'main_frame' ],
},
priority: 100,
}; However I suspect in your scenario that rule is not matched because your service worker script is fetched from another service worker script, not from a document ( const rule = {
id: TRUSTED_DIRECTIVE_BASE_RULE_ID+1,
action: { type: 'allowAllRequests' },
condition: {
initiatorDomains: [ ... ],
resourceTypes: [ 'script' ],
},
priority: 100,
}; If I could reproduce similar case on my side I would investigate a solution. |
looks like Maybe try blocking |
GHE page's hostname is If I don't exclude |
I added a filter to block anything from |
Couldn't get a SW on |
DNR's I found that a solution is to add an extra rule to exempt resources of type The fix will be in next release. |
Thanks for your patience and hard work! |
Seems like it's still an issue on |
Unfortunately without being able to investigate first-hand, I won't be able to make a diagnosis, which is necessary to come up with a solution. |
Our internal GitHub loads a shared worker at
which works.
The worker's only content is
but this fails.
![image](https://private-user-images.githubusercontent.com/567105/300994510-4f2da530-c637-4bfa-9ab8-36b4cfeb8883.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMzk0MTYsIm5iZiI6MTcyNjAzOTExNiwicGF0aCI6Ii81NjcxMDUvMzAwOTk0NTEwLTRmMmRhNTMwLWM2MzctNGJmYS05YWI4LTM2YjRjZmViODg4My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQwNzE4MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMmMxMDlhMTMwZWQ4N2QyNTI3OWQ4ZTg5NzFmZWFmZjAxYWE0YjQyMjllNzU1ZjYzNzIyZDhhZTcxZDJiOTcyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7qfzME46byKrTNeAcUGWcwE-x6mpOO7K5Ca2tMgjuIc)
I have
[workplace.com]
in theNo filtering
list, but it doesn't seem to work for theimportScripts()
call.Disabling the default
Ads, trackers, miners, and more
does make it work though, because[workplace.com]
is otherwise blocked.I have the filtering mode set to Optimal. I'm on Chrome
121.0.6167.140
.Dunno if this is an MV3 limitation or not 🤷♂️
The text was updated successfully, but these errors were encountered: