-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to translate header=
into DNR responseHeaders
condition
#157
Comments
Possibly because the following filter can't be translated into a DNR rule for multiple reasons:
|
@gorhill Sorry, can MV3 use I think this issue can be solved by *$script,3p,domain=minoplres.xyz,header=Access-Control-Allow-Headers:/megageocheckolololo/ if |
response header matching was added in Chrome M128, so whenever that version lands? |
From RuleCondition documentation, Conversion of |
header=
into DNR responseHeaders
condition
From my experience with ruffle-rs/ruffle#16694, this is doable with just a try/catch for adding the rule conditions on other browsers and older versions of Chrome that hadn't even begun implementing this rule condition, but on versions of Chrome that began implementing this feature behind a flag, adding the rule conditions does not throw but they take into account only their other conditions if the flag is not enabled, which may be undesirable. I had to use this code, suggested by Rob W from the Firefox team, to create a function to detect whether these conditions were really supported before registering them to work around that: w3c/webextensions#638 (comment). This is the Chrome bug indicating features developed behind a flag are not fully hidden behind the flag: https://issues.chromium.org/issues/347186592#comment9 It may be different for rules registered in the manifest. |
Prerequisites
URL(s) where the issue occurs.
https://yomovies.farm/
Description
Ads do not block by ublock origin lite on this site. when play video it pop up ads
Other extensions used
nothing.
Screenshot(s)
Screenshot(s)
Configuration
Details
The text was updated successfully, but these errors were encountered: