Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbsnews.com: breakage #177

Closed
Angelique465 opened this issue Aug 10, 2024 · 30 comments
Closed

cbsnews.com: breakage #177

Angelique465 opened this issue Aug 10, 2024 · 30 comments

Comments

@Angelique465
Copy link

uBOLite version: 925 (latest)
Configuration: "Complete"
Tested website: https://www.cbsnews.com/

It seems for some reason that no videos are played (black screen in video player).
In other videos the "play" button doesn't work (video doesn't start)
Maybe some rule/filter is giving this kind of issue.

@stephenhawk8054
Copy link
Member

Can you give exact link that has videos and the issue?

@stephenhawk8054 stephenhawk8054 changed the title CBSNEWS.COM - uBOLIte blocks video playing cbsnews.com: breakage Aug 10, 2024
@stephenhawk8054
Copy link
Member

Tested https://www.cbsnews.com/news/israel-gaza-airstrike-mosque-hamas/ with local build. I think it's fixed?

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

I get the black video after a long delay with local build and most up to date lists.

Plays fine if I set default to Basic.

Doesn't play if I set default mode to Optimal and site mode to Basic.


This suggests the issue might be caused by a redirect rule.

@Angelique465
Copy link
Author

Angelique465 commented Aug 10, 2024

screenshots of DOM

000001
000002

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

@Angelique465 We need a URL to reproduce on our side, not a screenshot. It's ok now we found one, but next time please provide an exact URL that we can just paste in the address bar and reproduce immediately, otherwise we spend time guessing trying to reproduce the issue.

Example of URL in address bar where the issue is reproducible:

https://www.cbsnews.com/news/debby-last-act-wet-windy-dangerous-northeast/

@Angelique465
Copy link
Author

@Angelique465
Copy link
Author

Angelique465 commented Aug 10, 2024

Sorry if I continue to send screenshots but sometimes a pictur is better than hundreds of words (and links are shown on top)
If I set site config to Optimal, still the video is blacked.
If I set site config to Basic, the video start image is shown, but CBS catches adblocker usage, as shown in this screenshot:

Admiral anti-adb

000004

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 10, 2024

Hmm... When I test on VPN to US, it shows ERR_UNSAFE_REDIRECT and the video turns black

image

When I use VPN to Hong Kong, it shows redirect successfully and the video plays

image

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 10, 2024

links are shown on top

@Angelique465 When you have issues, please always give the exact link to here. Don't say "link is in screenshot", we cannot put our eyes to type each character one-by-one in the URL to investigate, it's a huge waste of time.

@Angelique465
Copy link
Author

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

Wait, when I set default mode to Basic it works, but I get the issue after overriding site mode to Optimal, so a scriptlet is the issue?

@stephenhawk8054
Copy link
Member

Hmm... I haven't overrided the scriptlet in uBOL yet, but when I whitelist cbsnews.com##+js(abort-on-property-read, googletag) in EP, there's no delay in uBO.

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

when I whitelist cbsnews.com##+js(abort-on-property-read, googletag) in EP, there's no delay in uBO.

Yes, noticed that too. I removed that filter from EasyPrivacy and rebuild locally but problem is still there. I get many more errors in dev console with uBOL than with uBO, especially this one:

image

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 10, 2024

Ah yeah, mine plays fine when opening it first time in Incognito. After refreshing, it shows error again. There are multiple errors in the console like yours too.

ryanbr added a commit to easylist/easylist that referenced this issue Aug 10, 2024
@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

Here is what works for me:

Remove cbsnews.com from ##+js(abort-on-property-read, googletag)
Add ||cbsnews.com^$csp=worker-src 'none' (be sure to unregister cbsnews.com worker)

It still work without removing ##+js(abort-on-property-read, googletag), but then there will be a long delay before the video plays


I can't reproduce in Firefox so the csp= filter is needed only for Chromium.

@Angelique465
Copy link
Author

Angelique465 commented Aug 10, 2024

@ryanbr
Copy link

ryanbr commented Aug 10, 2024

Video loaded instantly here on https://cbssports.com/

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

I get anti-content blocker at https://cbssports.com/ with uBOL.

@Angelique465
Copy link
Author

Video loaded instantly here on https://cbssports.com/

000005

@ryanbr
Copy link

ryanbr commented Aug 10, 2024

@gorhill
Copy link
Member

gorhill commented Aug 10, 2024

@Angelique465 So not the same issue? "Video not playing" is not the same thing as "anti-blocker".

@Angelique465
Copy link
Author

Angelique465 commented Aug 10, 2024

Both sites (cbsnews and cbssports) have the same issue showing adblocker message. I can't reach the video to play it because of the blocking message box. Sorry for the misunderstood
And I bet all the CBS websites series have the same issues (video not playing and/or AdBlocker box).

@Angelique465
Copy link
Author

@gorhill
I rebuilt uBOLite again, before I removed the mv3-data folder from ./build to download latest filters. But the issues are still there, so maybe the filters are not yet refreshed. Have I to wait for the new version of uBOLite?

@stephenhawk8054
Copy link
Member

@Angelique465 You need to unregister the service worker from cbsnews.com first

@Angelique465
Copy link
Author

Angelique465 commented Aug 10, 2024

@gorhill sorry for the question which could seem stupid, but I'm a small "advanced" user only...
What do you mean with "unregister the service worker from cbsnews.com first"?
Actually uBOLite is not installed at all and I removed all the cache...
But when I install the new built version, config it and try in cbsnews/cbssports websites the issues are still there.
What else is needed?

@stephenhawk8054
Copy link
Member

Go to chrome://serviceworker-internals/, search for cbsnews.com and unregister the service worker there

@Angelique465
Copy link
Author

Darn I forgot to do this simple step... it's because ther's still a Chrome process running right?

@stephenhawk8054
Copy link
Member

Also, remind that the cbssports issue is not the same as the issue you mentioned at the 1st post. Don't mix detection and breakage issue here and say they are the same, it's very confusing for others.

cbssport.com detection issue is just addressed here: uBlockOrigin/uAssets@4ecf171

@Angelique465
Copy link
Author

@gorhill Now cbsnews is working fine! Thank you!
For cbssport now I'll rebuild uBOLite again.
You are right, next time I'll find some issues I'll post them separately.
Thank you.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Aug 10, 2024

@gorhill Sorry, do you think another scriptlet to unregister the service worker is a good idea to use together with csp? Currently ||cbsnews.com^$csp=worker-src 'none' still requires user to unregister it manually.

When I use rpnt like these, the service worker is automatically blocked and unregistered after I close the website

||cbsnews.com^$csp=worker-src 'none'
cbsnews.com##+js(rpnt, script, var CBSNEWS =, 'navigator.serviceWorker.getRegistrations().then((registrations=>{for(const registration of registrations){if(registration.scope.includes("cbsnews.com")){registration.unregister()}}}));var CBSNEWS =')

(Maybe wrapping around setTimeout could be more reliable?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants