-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocked elements reappear #3076
Comments
Do you have "My filters" lists enabled? Please share troubleshooting information. Go to the site, click the uBO toolbar icon -> the "chat" icon -> "Troubleshooting Information" text on the bottom -> select all, copy and attach here. |
@gorhill there is an issue in dev build (1.54 seems fine) - even with "My filters" list disabled, filters are applied. They are cached somehow - editing the content of "My filters" purges them.
|
This happens in 1.55.0 too. Toggling on then off "My filters" fix the issue. Pretty sure this is related to the MRU cache code I modified for cosmetic filters in last release. As for @UnitedMarsupials, the most likely explanation is that their "My filters" is not enabled, will need to wait for troubleshooting information. |
|
As suspected, your "My filters" is un-checked in "Filter lists" pane, you just need to check it:
Additionally, you shouldn't disable "uBlock filters -- Quick fixes", that list is used to push urgent fixes (Youtube for example). |
Oh... No idea, how that came about. Thank you. But shouldn't there have been a warning of some sort? Ah, great! Yes, this makes sense -- assuming, the blocking provides an explanation of some sort, unless you want to deal with tickets like "The picker-button is disabled for some reason" :-) |
Instead Of Disabling Element Picker Here gorhill/uBlock@bc641fc Why Not Disable Only The Create Button In The Element Picker ? This Is Problematic If I Want To Test Sites As I May Have Lots Of Filters In My Filters For That Site **Oh I Did Not Read The Post ;( |
I Once Again Ask For A Way To Use Element Picker While My Filter Is Disabled My Suggestion Disable Only The Create Button In Element Picker |
The current workaround/alternative is: On Desktop: in My filters: to press Ctrl+A & Tab (will select and comment out everything), then to press Save. (repeat the procedure to uncommment all again) On Mobile: instead of Ctrl+A, can tap and hold then select "Select all", but there is no Tab key on Android in most default virtual keyboards, as Android doesn't support it by default, but alternative keyboards with Tab support can be installed: https://www.reddit.com/r/androidapps/comments/lxe8a5/looking_for_a_good_alternative_keyboard_with_a/. Also on some keyboards after pressing Tab, Save button in My filters is still inactive, until "Enable my filters" checkbox is ticked off and then on (it happens so on SwiftKey, I didn't test on other keyboards so far, might be related to Codemirror quirks LINK). (I guess these workarounds might be a bit cumbersome for some users, especially on Mobile) |
Prerequisites
I tried to reproduce the issue when...
Description
While browsing news on this site, I added a bunch of cosmetic filters hiding away the cruft I don't like seeing on any news-page (invitations to sign up for a newsletter, "related items", etcætera):
While I was doing this, the elements were disappearing -- as they are supposed to. I then opened another article on the same site, and saw the same cruft appear...
Wondering, if somehow my filters weren't saved, I opened the "Own Filters" tab in the settings, and, sure enough, here they are (the above list is a copy-paste from the tab).
If I add the same filter again, the element will disappear -- and the duplicate filter will appear under the "Own Filters". But reloading the page will show the already-blocked element(s) once more... I even tried disabling all JavaScript for the site -- to no avail.
Note, the actual ads are properly disabled -- the "3rd-party filters" must be doing their job(s). But the blacklisted elements keep appearing after a page-reload.
I've been a user of uBO for years -- my current version is 1.5.4.0, inside Firefox-121.0 -- and I haven't run into this until recently :(
Another troublesome site is Reddit -- I have three identical entries already:
and yet, the silly widget keeps appearing, when I open the site.
A specific URL where the issue occurs.
https://www.offthepress.com/iowa-principal-who-put-self-in-harms-way-to-protect-students-from-mass-shooter-has-died/
Steps to Reproduce
See description
Expected behavior
Blacklisted elements remain hidden.
Actual behavior
Blacklisted elements reappear.
uBO version
1.5.4.0
Browser name and version
Firefox-121.0
Operating System and version
FreeBSD-14
The text was updated successfully, but these errors were encountered: