Regression: tabs created by user are closed by popup filter

[gwarser]

Details

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

Original discussion here: https://www.reddit.com/r/uBlockOrigin/comments/dpnpk8/ublock_possible_automatically_closing_tabs_when/

New tab is closed by matching popup filter when opened by middle click or Ctrl + click.

uBO had protection to not close tabs when opened directly by user: gorhill/uBlock@7713597

This stopped working after gorhill/uBlock@f204d24

$ git bisect good && ./tools/make-chromium.sh
f204d24bf4a7a5f70419bd8b0c7a87595f0a4181 is the first bad commit
commit f204d24bf4a7a5f70419bd8b0c7a87595f0a4181
Author: Raymond Hill <[email protected]>
Date:   Mon Sep 23 08:25:23 2019 -0400

    Match static popup filter against local context...

A specific URL where the issue occurs

https://www.reddit.com/r/uBlockOrigin/comments/dpnpk8/ublock_possible_automatically_closing_tabs_when/f695dan/

Steps to Reproduce

1. add ||netdna-ssl.com^$popup,third-party to My filters
2. middle click on http://ffp4g1ylyit3jdyti1hqcvtb-wpengine.netdna-ssl.com/opendesign/files/2019/06/FX_Design_Blog_Logos_Family.jpg

Original STR: https://www.reddit.com/r/uBlockOrigin/comments/dpnpk8/ublock_possible_automatically_closing_tabs_when/f695dan/

Expected behavior:

New tab should open as requested by user.

Actual behavior:

Tab is closed by filter.

Your environment

• uBlock Origin version: bisection
• Browser Name and version: Nightly 72 20191104094118, Chrome Version 77.0.3865.120 (Official Build) (64-bit)
• Operating System and version: Manjaro

[gorhill]

I added a test, no. 14, to detect this kind of regression: http://raymondhill.net/ublock/popup.html.

[uBlock-user]

add ||netdna-ssl.com^$popup,third-party to My filters
middle click on http://ffp4g1ylyit3jdyti1hqcvtb-wpengine.netdna-ssl.com/opendesign/files/2019/06/FX_Design_Blog_Logos_Family.jpg

Can't reproduce on my Nightly, it's a week old version.

[gwarser]

Can't reproduce on my Nightly, it's a week old version.

uBO version? Tested also on Firefox beta Version 71.0b6 Build ID 20191031113544

It's fixed.

[uBlock-user]

uBO version?

1.23.1b15

[gwarser]

Also with test 14 on http://raymondhill.net/ublock/popup.html ?

[uBlock-user]

Also with test 14

Yes, with ||example.com^$popup,third-party

logger never shows popup entry..

[gwarser]

Maybe somehow related with this about:blank entry? I don't see it in Chrome.

+0	/adhandler.aspx?$popup	--		3,3	popup	http://example.com/AdHandler.aspx?
+0					popup	about:blank

Filter: /adhandler.aspx?$popup
Filter list: EasyList

---

Try latest Nightly? If it does work in beta try bisecting https://mozilla.github.io/mozregression/

[uBlock-user]

It rather show example.com/adhandler.aspx, as new navigational entry in dark grey border.

It's okay, it's one of those times where something is working as expecting without a fix, it's rare but it's good and the fix is already implemented, not worth investing time in mozregression...