Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DecisionTaskStartedEventID to workflowInfo #1127

Merged
merged 4 commits into from
Sep 10, 2021

Conversation

longquanzheng
Copy link
Collaborator

What changed?
Add DecisionTaskStartedEventID to workflowInfo

Why?
In some use cases, users need to get the eventID for resetting certain activity/timer/etc.
This is the similar to BinaryChecksum which we are currently supporting.

How did you test it?
Existing tests

Potential risks
No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 27f52762-e037-41ba-80a8-a3d049506fae

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 71.652%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/workflow.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
internal/internal_task_pollers.go 2 81.53%
internal/compatibility/response.go 11 48.43%
Totals Coverage Status
Change from base Build 2e827765-7cf1-4470-a352-de8ddaf1cfe7: 0.1%
Covered Lines: 12188
Relevant Lines: 17010

💛 - Coveralls

@longquanzheng longquanzheng merged commit 9fdc4bc into master Sep 10, 2021
@longquanzheng longquanzheng deleted the qlong-decision-task-started-id branch September 10, 2021 22:31
@Groxx Groxx mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants