Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cadence.Version to 0.18.4 #1146

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Bump cadence.Version to 0.18.4 #1146

merged 2 commits into from
Nov 8, 2021

Conversation

Groxx
Copy link
Contributor

@Groxx Groxx commented Oct 29, 2021 •
edited
Loading

Will be merged and cherry-picked prior to tagging a release, but not before.

@coveralls
Copy link

coveralls commented Oct 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 36441898-9cb9-4a01-9797-6ce2ec51acbe

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 63.28%
Files with Coverage Reduction New Missed Lines %
internal/common/convert.go 3 84.62%
Totals Coverage Status
Change from base Build 27674722-bcdb-4f4e-a014-3c12b666bc84: -0.02%
Covered Lines: 12253
Relevant Lines: 19363
💛 - Coveralls

@Groxx Groxx merged commit 6122fec into uber-go:master Nov 8, 2021
@Groxx Groxx deleted the bump_libversion branch November 8, 2021 20:07
Groxx added a commit that referenced this pull request Nov 8, 2021
@Groxx
Bump cadence.Version to 0.18.4 (#1146)
a6b3235 
Prepwork for a release
@Groxx Groxx mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolodezny mkolodezny mkolodezny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Groxx @coveralls @mkolodezny